| [10:09:53] | * Egyptian[Home] has quit (Ping timeout: 276 seconds) |
| [10:16:37] | * hestenet has joined #aegir |
| [10:22:14] | * hestenet has quit (Ping timeout: 276 seconds) |
| [10:38:56] | * Egyptian[Home] has joined #aegir |
| [10:53:15] | * Egyptian[Home] has quit (Ping timeout: 276 seconds) |
| [11:06:45] | * Egyptian[Home] has joined #aegir |
| [11:11:20] | * Egyptian[Home] has quit (Ping timeout: 250 seconds) |
| [11:26:32] | * hestenet has joined #aegir |
| [11:32:12] | * hestenet has quit (Ping timeout: 244 seconds) |
| [12:18:50] | * Egyptian[Home] has joined #aegir |
| [12:19:49] | * Egyptian[Home] has quit (Client Quit) |
| [12:21:29] | * Egyptian[Home] has joined #aegir |
| [12:28:29] | * hestenet has joined #aegir |
| [12:33:33] | * hestenet has quit (Ping timeout: 240 seconds) |
| [12:40:36] | * Egyptian[Home] has quit (Ping timeout: 250 seconds) |
| [13:46:59] | * Egyptian[Home] has joined #aegir |
| [14:30:46] | * hestenet has joined #aegir |
| [14:36:51] | * hestenet has quit (Ping timeout: 276 seconds) |
| [14:39:38] | * Egyptian[Home] has quit (Ping timeout: 276 seconds) |
| [15:32:31] | * hestenet has joined #aegir |
| [15:37:45] | * hestenet has quit (Ping timeout: 246 seconds) |
| [16:07:37] | * rominronin has joined #aegir |
| [16:28:04] | * ybabel has joined #aegir |
| [16:31:32] | * boshtian has joined #aegir |
| [16:34:00] | * hestenet has joined #aegir |
| [16:39:21] | * hestenet has quit (Ping timeout: 246 seconds) |
| [17:32:39] | * HaloFX has quit (Quit: Leaving) |
| [17:38:55] | * HaloFX has joined #aegir |
| [17:40:10] | * HaloFX has quit (Client Quit) |
| [17:41:05] | * HaloFX has joined #aegir |
| [18:36:40] | * hestenet has joined #aegir |
| [18:39:55] | * HaloFX has quit (Quit: Leaving) |
| [18:42:13] | * hestenet has quit (Ping timeout: 265 seconds) |
| [19:39:01] | * hestenet has joined #aegir |
| [19:43:43] | * hestenet has quit (Ping timeout: 252 seconds) |
| [20:39:07] | * gandhiano_ has joined #aegir |
| [20:40:04] | * hestenet has joined #aegir |
| [20:42:01] | * Egyptian[Home] has joined #aegir |
| [20:45:30] | * hestenet has quit (Ping timeout: 250 seconds) |
| [21:35:32] | * netrunner has joined #aegir |
| [21:41:32] | * hestenet has joined #aegir |
| [21:46:55] | * hestenet has quit (Ping timeout: 252 seconds) |
| [22:10:14] | * gandhiano_ has quit (Ping timeout: 260 seconds) |
| [22:19:15] | * hestenet has joined #aegir |
| [22:26:36] | * noecc has joined #aegir |
| [22:31:40] | * zombiebeard has joined #aegir |
| [22:56:33] | * gandhiano_ has joined #aegir |
| [23:07:33] | * ergonlogic has quit (Remote host closed the connection) |
| [23:08:33] | * ergonlogic has joined #aegir |
| [23:41:15] | * Yaazkal has joined #aegir |
| [23:57:32] | * hestenet has quit (Remote host closed the connection) |
| [00:04:17] | * hestenet has joined #aegir |
| [00:29:44] | * boshtian has quit (Remote host closed the connection) |
| [00:29:59] | * boshtian has joined #aegir |
| [00:36:52] | * boshtian has quit (Ping timeout: 260 seconds) |
| [00:38:42] | * Egyptian[Home] has quit (Quit: Leaving.) |
| [00:52:56] | * rominronin has quit (Remote host closed the connection) |
| [01:03:02] | <colan> | gboudrias: pong |
| [01:04:01] | <gboudrias> | colan: I created an issue after all: https://www.drupal.org/node/2721373 |
| [01:04:01] | <hefring> | https://www.drupal.org/node/2721373 => The request must specify a site nid to clone [#2721373] => 0 comments, 1 IRC mention |
| [01:07:02] | <colan> | reviewing... |
| [01:15:05] | <colan> | gboudrias: responded. |
| [01:15:12] | <colan> | thoughts? |
| [01:16:51] | <gboudrias> | colan: I don't think it works like you're describing, have you tested without nid? doesn't work for me |
| [01:17:21] | <gboudrias> | I don't see how it could based on the resource definition |
| [01:17:47] | <colan> | gboudrias: yeah, actually worked for me. :) |
| [01:19:30] | <gboudrias> | colan: Ok I'll do more tests, but the task create resource has nid set to optional => False, how is this overridden? |
| [01:20:04] | <colan> | gboudrias: didn't even know about that, but let me try again. stand by. |
| [01:20:16] | <gboudrias> | ok thanks |
| [01:23:29] | <colan> | gboudrias: yup, goes through to my error "Cannot populate site clone task: ID of site to clone was not specified. Either save it in the settings, or provide the site node ID as 'nid' in the POST form data." so that's where it can be added from the settings. |
| [01:24:06] | <gboudrias> | colan: Ah okay, I'd missed that, I'll confirm and close the issue |
| [01:24:35] | <colan> | gboudrias: i guess that should now be updated for the site name. anyway, let me know if this is a bad idea? |
| [01:25:24] | <gboudrias> | colan: Yeah updating for the site name is definitely a good idea |
| [01:25:56] | <colan> | gboudrias: also, thanks for catching the hosting_get_site_by_url() note. i'll upload another patch using that instead. |
| [01:26:03] | <gboudrias> | colan: Also I was thinking for that whole function we should probably throw exceptions on errors. If people are using the aegir_saas user we can probably assume an expected workflow. |
| [01:26:09] | <gboudrias> | cool |
| [01:27:24] | <gboudrias> | (otherwise we just get nothing on the client side and the clone still goes through, which is probably bad) |
| [01:27:25] | <colan> | gboudrias: yeah, reworking that is "Currently, errors are only logged to the server. Return useful status codes/info instead of returning 200 OK with no data. See #2370491: Return a custom status code? for a way to do this." is about. maybe let's make that its own issue? |
| [01:27:50] | <gboudrias> | Right |
| [01:28:06] | <gboudrias> | Yeah, I wanted to make the patch first but I guess the idea is pretty straightforward |
| [01:28:08] | <colan> | gboudrias: maybe call it "Enhance error reporting" or some such? |
| [01:28:34] | <gboudrias> | Sounds good |
| [01:28:50] | <colan> | i'll open it now. |
| [01:29:53] | * Egyptian[Home] has joined #aegir |
| [01:34:30] | <colan> | gboudrias: https://www.drupal.org/node/2721733 - i don't have a good sense of how the exception handling / error workflows work in the api, so feel free to take this on. |
| [01:34:31] | <hefring> | https://www.drupal.org/node/2721733 => Enhance SaaS error reporting [#2721733] => 0 comments, 1 IRC mention |
| [01:35:14] | <gboudrias> | colan: 10-4 |
| [01:35:16] | <colan> | as in, is there a standard way to return non-200s via exceptions? |
| [01:36:12] | <colan> | when i took a quick look, it didn't seem like Services supported this natively. |
| [01:38:21] | * Yaazkal has quit (Ping timeout: 246 seconds) |
| [01:40:02] | * Egyptian[Home] has quit (Ping timeout: 276 seconds) |
| [01:44:16] | <gboudrias> | colan: Doesn't seem like it |
| [01:44:44] | <gboudrias> | colan: But I think halting is still better than continuing for our use case, and an error message is still better than none |
| [01:47:52] | * Egyptian[Home] has joined #aegir |
| [01:53:30] | * rominronin has joined #aegir |
| [01:58:19] | * gandhiano_ has quit (Ping timeout: 260 seconds) |
| [01:58:53] | * rominronin has quit (Ping timeout: 276 seconds) |
| [01:59:39] | <colan> | yep. |
| [02:00:11] | * Egyptian[Home] has quit (Ping timeout: 276 seconds) |
| [02:08:41] | * ybabel has quit (Quit: ybabel) |
| [02:11:29] | * freiheit has joined #aegir |
| [02:27:04] | * hestenet has quit (Read error: Connection reset by peer) |
| [02:27:25] | * hestenet has joined #aegir |
| [02:41:00] | * noecc has left #aegir ("pax") |
| [02:52:20] | * hestenet has quit (Remote host closed the connection) |
| [02:53:18] | * hestenet has joined #aegir |
| [02:54:50] | * rominronin has joined #aegir |
| [02:54:56] | * gandhiano_ has joined #aegir |
| [02:58:02] | * hestenet has quit (Ping timeout: 260 seconds) |
| [02:59:47] | * rominronin has quit (Ping timeout: 260 seconds) |
| [03:29:19] | * hestenet has joined #aegir |
| [03:42:08] | * gusaus has joined #aegir |
| [03:53:59] | * rominronin has joined #aegir |
| [03:58:57] | * rominronin has quit (Ping timeout: 276 seconds) |
| [04:00:35] | <gboudrias> | colan: I'll probably do the hosting_saas_utils merge later tonight, I'll put it under submodules/hosting_saas/utils if that sounds good |
| [04:00:46] | <gboudrias> | (There'll be a lot of refactoring needed most likely) |
| [04:00:55] | * gandhiano_ has quit (Ping timeout: 252 seconds) |
| [04:03:28] | <colan> | gboudrias: oh fantastic! thanks. i think it would be better to just keep it in the main hosting_saas, and even keep the variable names the same (less work). |
| [04:03:51] | <gboudrias> | colan: hmm good point, more work but it'll be better, let's do that |
| [04:04:17] | <gboudrias> | But I'll have to change the function names anyhow |
| [04:04:34] | <colan> | gboudrias: great. it's really just more options on the same form, so i don't see the point of making it a separate module. |
| [04:04:42] | <colan> | yeah, sorry. ;) |
| [04:04:45] | <gboudrias> | yeah fair enough |
| [04:04:46] | <gboudrias> | hahah |
| [04:04:58] | <colan> | another module would be bad for UX & such. |
| [04:05:28] | <colan> | One module to rule them all! |
| [04:05:54] | * colan goes back to the EFQ stuff. |
| [04:06:48] | <colan> | this would be much easier if EntityFieldQueries supported joins in D7, but i think i've worked around it. |
| [04:46:44] | * hestenet has quit (Remote host closed the connection) |
| [04:54:47] | * rominron_ has joined #aegir |
| [05:00:32] | * rominron_ has quit (Ping timeout: 260 seconds) |
| [05:01:04] | * hestenet has joined #aegir |
| [05:07:53] | * ceaucari has joined #aegir |
| [05:46:35] | * gandhiano_ has joined #aegir |
| [05:48:00] | <colan> | gboudrias: (or anyone else) can you review https://www.drupal.org/node/2720439#comment-11172249 when you get a chance? |
| [05:48:01] | <hefring> | https://www.drupal.org/node/2720439 => Add site autocompletion & ID retrieval without loading nodes [#2720439] => 5 comments, 1 IRC mention |
| [05:52:59] | * Egyptian[Home] has joined #aegir |
| [05:56:14] | * freiheit has left #aegir () |
| [05:57:07] | * rominronin has joined #aegir |
| [06:02:23] | * ceaucari has quit (Quit: Textual IRC Client: www.textualapp.com) |
| [06:02:27] | * rominronin has quit (Ping timeout: 276 seconds) |
| [06:05:48] | * Egyptian[Home] has quit (Ping timeout: 250 seconds) |
| [06:14:31] | <viashimo> | is upgrading from aegir2 to aegir3 supported, or is the recommended path to install fresh & re-configure as before? |
| [06:19:09] | * ceaucari has joined #aegir |
| [06:41:33] | * ceaucari has quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| [06:58:14] | * rominronin has joined #aegir |
| [06:58:34] | <gboudrias> | viashimo: Using the debian packages should work, that's how I did it on most of my servers |
| [06:59:26] | <gboudrias> | I don't know about manual install but there shouldn't really be a difference. Worth a try :) |
| [06:59:36] | <gboudrias> | (As long as you have a backup) |
| [07:03:24] | * rominronin has quit (Ping timeout: 260 seconds) |
| [07:05:18] | * hestenet has quit (Remote host closed the connection) |
| [07:06:45] | * hestenet has joined #aegir |
| [07:13:01] | * hestenet has quit (Remote host closed the connection) |
| [07:23:13] | * hestenet has joined #aegir |
| [07:30:09] | <viashimo> | gboudrias: cool, thx for the feedback. the mentions are fairly sparse and readthedocs mostly points to outdated community docs page |
| [07:30:28] | <gboudrias> | viashimo: hmm yeah, any help on those would be appreciated :) |
| [07:42:29] | * hestenet has quit (Ping timeout: 260 seconds) |
| [07:44:20] | * hestenet has joined #aegir |
| [07:59:19] | * rominronin has joined #aegir |
| [08:00:27] | * zombiebeard has quit (Quit: zombiebeard) |
| [08:03:14] | * hestenet has quit (Remote host closed the connection) |
| [08:04:32] | * rominronin has quit (Ping timeout: 250 seconds) |
| [08:11:26] | * TommyCox has joined #aegir |
| [08:41:09] | <gboudrias> | colan: Still can't get the request to work without a site NID, mind copy-pasting the request Postman is generating? |
| [08:41:28] | <gboudrias> | oh nvm |
| [08:41:36] | <gboudrias> | Missing a module |
| [08:48:49] | * gusaus has quit (Quit: gusaus) |
| [08:50:07] | <gboudrias> | colan: Yeah no still can't do it |
| [09:00:25] | * rominronin has joined #aegir |
| [09:05:32] | * rominronin has quit (Ping timeout: 260 seconds) |
| [09:07:41] | <colan> | gboudrias: i just found your problem. you need to add the key nid, just don't assign it a value. |
| [09:08:33] | <colan> | i'll agree this is a bit of API abuse here, but it works. ;) |
| [09:09:05] | <gboudrias> | colan: Heh, yep, looks like that was it |
| [09:14:41] | * gusaus has joined #aegir |
| [09:20:45] | * Yaazkal has joined #aegir |
| [09:37:24] | * gandhiano_ has quit (Ping timeout: 260 seconds) |
| [09:59:48] | * netrunner has quit (Ping timeout: 250 seconds) |
