| [13:13:29] | * hefring has joined #aegir |
| [14:24:48] | * drakythe is now known as zz_drakythe |
| [16:03:14] | * cmcintosh has joined #aegir |
| [17:21:59] | * cmcintosh has quit (Read error: Connection reset by peer) |
| [18:26:12] | * boshtian has joined #aegir |
| [20:01:18] | * ybabel has joined #aegir |
| [01:20:53] | * oluabbeys has joined #aegir |
| [01:25:04] | * oluabbeys has quit (Client Quit) |
| [01:41:13] | * shaneonabike1 has joined #aegir |
| [01:43:28] | <colan> | helmo: bgm jonpugh thoughts on https://gitlab.com/aegir/hosting_https/issues/12 ? Forgot to ask about this yesterday. |
| [01:49:24] | <colan> | hefring: tell memtkmcc thoughts on https://gitlab.com/aegir/hosting_https/issues/12 ? |
| [01:49:24] | <hefring> | colan: I'll pass that on when memtkmcc is around. |
| [02:13:25] | * boshtian has quit (Quit: boshtian) |
| [02:29:37] | <bgm> | colan: I don't have a strong opinion on that. obviously, preference for whatever is the simplest. sometimes I find aegir a bit too modular :) |
| [02:31:54] | <colan> | i'm tempted to just put "git clone --recursive ..." in the README. |
| [02:32:01] | <colan> | bgm: ^^ |
| [02:32:05] | <bgm> | fine with me |
| [02:33:12] | <jonpugh> | colan: does drush make init git submodules? If not I think you are better off adding as a "library" |
| [02:33:47] | <colan> | jonpugh: not sure. haven't used make in a while. |
| [02:34:00] | <colan> | the library way is more formal so i like that idea too. |
| [02:34:23] | <jonpugh> | otherwise we wouldn't be able to add it to a makefile and forget it. |
| [02:34:45] | <jonpugh> | yeah, you could just have the script downloaded using the makefile |
| [02:35:08] | <jonpugh> | gitmodules are useful if you are developing both projects simultaneously |
| [02:35:20] | <colan> | not sure folks still use those anymore, makefiles. |
| [02:35:36] | <jonpugh> | drush make files? |
| [02:35:37] | <colan> | it adds mor to the instructions, etc. |
| [02:35:41] | <colan> | yep |
| [02:35:52] | <jonpugh> | except aegir and derivatives :) |
| [02:36:11] | <colan> | jonpugh: i just do everything with git via hosting_git. ;) |
| [02:36:29] | <jonpugh> | yeah but for hostmaster :) |
| [02:36:41] | <jonpugh> | it's going to be a makefile. seems like it's targeted for core? |
| [02:36:56] | <jonpugh> | ok, do both then. |
| [02:37:08] | <jonpugh> | have a git submodule for people that are going to manually install. |
| [02:37:14] | <colan> | ha, well, what are we dong now for libraries? |
| [02:37:23] | <jonpugh> | hostmaster.make |
| [02:37:32] | <colan> | right. |
| [02:37:39] | <colan> | so not using the libraries modules. |
| [02:37:52] | <jonpugh> | yeah, not needed |
| [02:37:53] | <jonpugh> | https://github.com/opendevshop/devmaster/blob/1.x/devmaster.make#L78 |
| [02:38:00] | <colan> | be nice if we ha composer up & running. |
| [02:38:44] | <colan> | let's focus on getting into core later. i just want folks to start testing it. |
| [02:39:42] | <colan> | i think git clone recursive will be good for now, unless someone convinces me otherwise. down the road, we can rework for core inclusion. |
| [02:40:40] | <colan> | this is a one-step way to try it without needing extra tooling. |
| [02:41:00] | <jonpugh> | like I said, do both :) |
| [02:41:00] | <colan> | i should get the queue done today, and then put out a beta. |
| [02:41:19] | <jonpugh> | If I were to add it to devmaster, I would add to makefile |
| [02:41:31] | <jonpugh> | your project can just use the gitsubmodule |
| [02:41:56] | <jonpugh> | but when included in a drupal stack, it should be possible to include it with make instead of git. |
| [02:42:26] | <colan> | is there an example of that somewhere? i'll probably leave this for someone else, but curious. |
| [02:42:49] | <jonpugh> | colan: https://github.com/opendevshop/devmaster/blob/1.x/devmaster.make#L77 |
| [02:42:58] | <jonpugh> | you can download any file into any location like that |
| [02:43:07] | <jonpugh> | ; JQuery TimeAgo plugin |
| [02:43:07] | <jonpugh> | libraries[timeago][download][type] = get |
| [02:43:07] | <jonpugh> | libraries[timeago][download][url] = https://raw.githubusercontent.com/rmm5t/jquery-timeago/v1.5.3/jquery.tim... |
| [02:43:07] | <jonpugh> | libraries[timeago][destination] = libraries |
| [02:43:56] | <jonpugh> | is "path to dehydrated" a variable? |
| [02:44:56] | <colan> | where are you looking? |
| [02:45:50] | <colan> | it's in .gitmodules |
| [02:46:07] | <colan> | there's a softlink pointing to the shell sccript in that location. |
| [02:48:21] | <jonpugh> | If you added a "path to dehydrated script" variable I think that would be better. |
| [02:49:25] | <colan> | yeah, a lot of modules do that.not a bad idea. this is what i inherited from ergonlog1c ;) |
| [02:50:01] | <colan> | though i think i'm partly to blame as IIRC, i was sitting next to him. |
| [02:51:15] | * ergonlog1c gets all the blame :p |
| [02:51:33] | <colan> | hey, you were driving. ;) |
| [03:06:44] | * ybabel has quit (Quit: ybabel) |
| [03:45:36] | <colan> | ergonlog1c: in the queue implementation, Probes is doing "drush_invoke_process('@self', 'hosting-task', ...", but can i simply call hosting_task()? |
| [03:46:04] | <colan> | not sure what the point of that is. |
| [03:52:34] | <colan> | er, hosting_add_task(). |
| [03:53:36] | <ergonlog1c> | colan: can you point me towards the relvant code? |
| [03:54:19] | <colan> | oh, i guess this causes it to fork. |
| [03:54:24] | <colan> | ergonlog1c: http://cgit.drupalcode.org/hosting_site_backup_manager/tree/hosting_back... |
| [03:54:59] | <colan> | this is another one doing the same thing. so it looks like it won't fork it you simply run hosting_add_task, and i'm assuming you want it to if it's a batch job? |
| [03:55:26] | <ergonlog1c> | iirc, hosting_add_task() only adds the task to the queue |
| [03:55:42] | <ergonlog1c> | `drush hosting-task` runs a task |
| [03:55:48] | <colan> | it doesn't run it? |
| [03:55:58] | <colan> | oic. |
| [03:56:35] | <colan> | ergonlog1c: but if it's in the queue, won't the task queue pick it up and run it? |
| [03:57:08] | <ergonlog1c> | yep |
| [03:57:16] | <ergonlog1c> | when it gets around to it |
| [03:57:32] | <colan> | ergonlog1c: think that's good enough? |
| [03:57:47] | <ergonlog1c> | for verify? most certainly |
| [03:58:09] | <colan> | ergonlog1c: yeah, b/c verify is what updates the certs. |
| [03:58:35] | <colan> | ok, cool. hosting_add_task() it is. |
| [06:08:57] | * hestenet has quit (Ping timeout: 260 seconds) |
| [07:33:09] | * shaneonabike1 has quit (Quit: Leaving.) |
| [07:40:44] | * hestenet has joined #aegir |
| [10:42:05] | * hestenet has quit (Read error: Connection reset by peer) |
| [10:42:31] | * hestenet has joined #aegir |
