| [10:10:56] | * Guest43557 has joined #aegir |
| [10:24:18] | * Guest43557 has quit (Quit: Later!) |
| [13:40:25] | * realityloop has joined #aegir |
| [15:46:06] | * realityloop has quit (Quit: Leaving..) |
| [17:10:09] | * reaper013 has joined #aegir |
| [17:26:11] | * ybabel has joined #aegir |
| [20:18:30] | * theMusician has quit (Ping timeout: 240 seconds) |
| [20:23:04] | * theMusician has joined #aegir |
| [22:58:52] | * v20th has joined #aegir |
| [23:26:24] | <colan> | ergonlogic: in which of the 3 modules would support be added for a new report? i'd like to add an issue placeholder for supporting https://www.drupal.org/project/quenforcer (just released a beta, now with an image on the project page) |
| [23:26:43] | <colan> | ...which I hope to get to eventually. |
| [23:44:22] | * mlhess has quit (Remote host closed the connection) |
| [23:44:53] | * mlhess has joined #aegir |
| [00:06:40] | * v20th has quit (Ping timeout: 246 seconds) |
| [00:18:56] | * v20th has joined #aegir |
| [00:56:52] | * reaper013 has quit (Quit: Page closed) |
| [01:13:33] | <ergonlogic> | colan: I think what you're looking for is a new "probe", not a new "report". If there's a Hosting component (e.g. hosting_civicrm) then that'd be the place to define the new probe. Otherwise, you might need to create a new (though small) module to add a new probe. |
| [01:13:39] | * theMusician has quit (Quit: theMusician) |
| [01:15:53] | * theMusician has joined #aegir |
| [01:16:02] | <colan> | ergonlogic: Okay, so there would be a hook implementation or some such used by the API module? |
| [01:16:27] | <ergonlogic> | right. I'm pretty sure it's documented in the project descriptions |
| [01:16:45] | <ergonlogic> | and READMEs |
| [01:17:00] | <ergonlogic> | but If I missed anything, I'm happy to fill out the gaps |
| [01:17:41] | <ergonlogic> | also, I OOPified the distribution module, along the lines we discussed. Everything is making a lot more sense now |
| [01:18:02] | * theMusician has quit (Client Quit) |
| [01:18:02] | <colan> | Great, thanks. I should read those instead docs of asking questions. ;-) |
| [01:18:08] | <colan> | Okay, cool. |
| [01:18:09] | <ergonlogic> | though... I may have added one or two too many classes |
| [01:18:14] | <ergonlogic> | but whatever |
| [01:19:12] | <ergonlogic> | colan: well, if they're reasoably clear, we could look at adding them to the docs repo, once we consider adding the reporting stuff to the distro |
| [01:19:48] | <colan> | Er, i mean i should read those modules' docs. |
| [01:20:10] | <ergonlogic> | in the end though, you just need to (IIRC) implement a hook that exposes your probe classes, then those classes themselves. |
| [01:20:20] | <ergonlogic> | right, that's what I'd understood |
| [01:21:16] | <ergonlogic> | IIRC, there's also an alter hook available. Which we might want to use to remove the site_audit probes that aren;t yet fully functional. |
| [01:21:36] | <colan> | ergonlogic: So that's in an aegir module or in a client site module? |
| [01:21:44] | <ergonlogic> | Aegir |
| [01:22:51] | <ergonlogic> | most of these are based on running some "drush eval" code against hosted sites |
| [01:23:31] | <ergonlogic> | it's handy since we already have a secure mechanism to connect to the site as the root user |
| [01:23:53] | <ergonlogic> | and doesn't require any changes to the hosted sites themselves |
| [01:24:34] | <ergonlogic> | it can be a bit tricky to write those drush eval probes though, since you end up having to sometimes escape quotes and such. |
| [01:24:47] | <colan> | ergonlogic Well I've only got a module running on the client site for now so could i add this code to one of the 3 you have? Or would i need a completely new one? |
| [01:25:08] | <ergonlogic> | feel free to add it to an existing one, if you like |
| [01:25:21] | <ergonlogic> | you are co-maintainer of all three now |
| [01:25:40] | <colan> | That was really my original question, which of those would be most appropriate? ;-) |
| [01:26:04] | <ergonlogic> | ah, sorry, I misread that |
| [01:26:35] | <ergonlogic> | I was up 'til all hours last night, shearing my dog who decided to tussle with a skunk :-/ |
| [01:26:59] | <colan> | Sounds like a party. |
| [01:27:44] | <ergonlogic> | ugh |
| [01:28:04] | <ergonlogic> | anyway, hosting_report defines some basic probes, so you *could* add it there |
| [01:28:20] | <ergonlogic> | tbh, though, I think you're better off with a small new module |
| [01:28:57] | <ergonlogic> | since, presumably you're probing for data that isn't going to be available for sites that aren;t running your module |
| [01:29:40] | * theMusician has joined #aegir |
| [01:30:17] | <colan> | Okay, cool. I think adding it there would be better as one shouldn't have to install so many modules. It can always do nothing if not implemented on the target. |
| [01:30:53] | <ergonlogic> | right. You should be able to set it to be disabled by default |
| [01:39:11] | <colan> | placeholder: https://www.drupal.org/node/2866405 |
| [01:39:13] | <hefring> | https://www.drupal.org/node/2866405 => Add support for site quotas [#2866405] => 0 comments, 1 IRC mention |
| [02:04:18] | <ergonlogic> | colan: considering that the relevant setting are deployed via hosting_variables (IIRC), it might be interesting to add probes there too. |
| [03:00:48] | * theMusician has quit (Ping timeout: 240 seconds) |
| [03:19:56] | <ergonlogic> | huh... there's a 10-day waiting period for opting-into security advisory coverage for new modules |
| [03:50:53] | * theMusician has joined #aegir |
| [04:08:50] | * theMusician has quit (Quit: theMusician) |
| [06:10:28] | * ybabel has quit (Quit: ybabel) |
| [06:40:28] | * theMusician has joined #aegir |
| [09:02:31] | * v20th has quit (Ping timeout: 246 seconds) |
| [09:42:12] | * realityloop has joined #aegir |
| [09:49:14] | * realityloop has quit (Quit: Leaving..) |
| [09:56:21] | * theMusician has quit (Quit: theMusician) |
