| [17:11:35] | * mstenta has quit (Ping timeout: 255 seconds) |
| [17:23:54] | * mstenta has joined #aegir |
| [19:09:09] | * reaper013 has joined #aegir |
| [19:31:08] | * anarcat has quit (Read error: Connection reset by peer) |
| [19:31:14] | * anarchat has joined #aegir |
| [20:05:23] | * ybabel has joined #aegir |
| [20:46:01] | * zz_drakythe is now known as drakythe |
| [23:42:54] | * reaper013 has quit (Quit: Page closed) |
| [00:28:07] | <helmo42[m]> | I've been pushing hard this week to get hosting_https to a stable release ... please review https://gitlab.com/aegir/hosting_https/issues/29 |
| [02:05:44] | * mstenta has quit (Ping timeout: 255 seconds) |
| [02:18:06] | * mstenta has joined #aegir |
| [04:32:47] | * shaneonabike1 has joined #aegir |
| [05:46:21] | * theMusician has quit (Ping timeout: 260 seconds) |
| [06:09:06] | * theMusician has joined #aegir |
| [06:09:07] | * theMusician has quit (Client Quit) |
| [06:32:56] | * theMusician has joined #aegir |
| [07:17:38] | * ybabel has quit (Quit: ybabel) |
| [07:25:48] | * shaneonabike1 has quit (Quit: Leaving.) |
| [07:53:06] | <colan> | ergonlogic: can you confirm if i'm on the right track here? https://www.drupal.org/project/hosting_composer/issues/2930610 |
| [07:54:33] | <ergonlogic[m]> | looking |
| [07:56:54] | <ergonlogic[m]> | @colan no, I think it really should be stand-alove |
| [07:56:56] | <ergonlogic[m]> | alone* |
| [07:57:29] | <colan> | ergonlogic: why? can it do anything on its own? |
| [07:58:01] | <ergonlogic[m]> | I'm checking, but I'm pretty sure it'll run "composer install" |
| [07:58:50] | <ergonlogic[m]> | which doesn't necessarily require the platform to either be built with Composer, nor cloned from git |
| [08:00:03] | <ergonlogic[m]> | likewise, you may want to build/clone a platform (with the sub-modules), but not run `composer install` automatically |
| [08:01:12] | <ergonlogic[m]> | At least, I think that was my logic there (iirc) |
| [08:02:49] | <colan> | hmm. well, that certainly wasn't obvious. |
| [08:17:10] | <ergonlogic[m]> | I agree |
| [08:17:40] | <ergonlogic[m]> | fwiw, I think your patch is reasonable. It just makes it a little less flexible |
| [08:18:21] | <ergonlogic[m]> | that said, it might me a good choice |
| [08:19:34] | <ergonlogic[m]> | iirc, I think I'd intended to add a checkbox somewhere (on the platform form?) that'd allow control over that behaviour |
| [08:20:20] | <ergonlogic[m]> | after that, I'd have done something akin to your patch |
| [08:21:24] | <ergonlogic[m]> | but since it's probably 90% of users who *will* want to run `composer install`, you can go ahead with your patch, and we can add the form element as a feature down the road. |
| [08:40:11] | * theMusician has quit (Quit: theMusician) |
| [08:43:10] | <colan> | ergonlogic: ah, okay. Was just about to revert it. Will leave in then. Feel free to add comments in the ticket or add a follow up. |
| [08:44:16] | <colan> | Not sure i fully understand all of the intricacies. |
| [08:44:18] | <ergonlogic[m]> | will do |
| [08:45:35] | * theMusician has joined #aegir |
| [08:48:03] | <ergonlogic[m]> | revised my comments here and added them to the issue. Set it to RTBC, too, though I haven't tested it. |
| [08:54:44] | <colan> | ergonlogic: thanks. trying to see if i can quickly deploy sites from latest https://git.drupal.org/project/drupal.git to test new core patches & such, where i'll actually get a vendor directory. |
| [08:57:59] | <colan> | hmm. when i create the platform using git, still getting `require(/var/aegir/platforms/drupal_core_8.5.x/vendor/autoload.php): failed` so the vendor dir didn't get generated. |
| [08:59:54] | <ergonlogic[m]> | make sure you `drush cc`, so that the hooks are found |
| [09:07:32] | <colan> | nope, will dig into this tomorrow. |
| [09:13:20] | * theMusician has quit (Quit: theMusician) |
| [09:25:03] | * theMusician has joined #aegir |
| [09:56:28] | * ponies[m] has quit (Ping timeout: 240 seconds) |
| [09:56:29] | * memtkmcc has quit (Ping timeout: 240 seconds) |
| [09:56:29] | * ricardoamaro_ has quit (Ping timeout: 240 seconds) |
| [09:56:48] | * Github[jonpughma has quit (Ping timeout: 240 seconds) |
| [09:57:57] | * Github[jonpughma has joined #aegir |
| [09:58:02] | * memtkmcc has joined #aegir |
| [09:58:02] | * ponies[m] has joined #aegir |
| [09:58:18] | * ricardoamaro_ has joined #aegir |
| [10:13:16] | * theMusician has quit (Quit: theMusician) |
| [10:16:27] | * theMusician has joined #aegir |
