| [11:18:02] | * theMusician has quit (Quit: theMusician) |
| [12:52:07] | * antonioG4 has joined #aegir |
| [12:53:13] | * antonioG4 has quit (Client Quit) |
| [15:37:03] | * orangey has quit (Read error: Connection reset by peer) |
| [15:45:40] | * orangey has joined #aegir |
| [19:02:16] | * ybabel has joined #aegir |
| [19:19:04] | * bgm has quit (Ping timeout: 252 seconds) |
| [19:19:53] | * reaper013 has joined #aegir |
| [19:22:59] | * bgm has joined #aegir |
| [19:22:59] | * bgm has quit (Changing host) |
| [19:22:59] | * bgm has joined #aegir |
| [19:27:27] | * bgm has quit (Ping timeout: 246 seconds) |
| [19:29:09] | * bgm has joined #aegir |
| [19:29:09] | * bgm has quit (Changing host) |
| [19:29:09] | * bgm has joined #aegir |
| [19:34:39] | * joestewart has quit (Ping timeout: 248 seconds) |
| [19:36:01] | * joestewart_ has quit (Ping timeout: 256 seconds) |
| [19:41:54] | * joestewart has joined #aegir |
| [19:42:20] | * joestewart_ has joined #aegir |
| [20:49:05] | * joestewart has quit (Ping timeout: 276 seconds) |
| [20:52:13] | * joestewart_ has quit (Quit: No Ping reply in 180 seconds.) |
| [20:53:21] | * joestewart has joined #aegir |
| [20:53:41] | * joestewart_ has joined #aegir |
| [21:18:16] | * ybabel has quit (Read error: Connection reset by peer) |
| [21:19:11] | * ybabel has joined #aegir |
| [01:13:14] | <helmo42[m]> | johnpugh: FYI: The video on http://opendevshop.com/ is broken |
| [02:01:16] | * theMusician has joined #aegir |
| [02:36:49] | <colan> | helmo42: I don't think he's in here at the moment. |
| [02:37:21] | <jonpugh1> | who me? |
| [02:41:24] | <helmo42[m]> | @freenode_jonpugh[m]:matrix.org: Yes ... I mentioned you a bit earlier |
| [02:41:25] | <helmo42[m]> | The video on http://opendevshop.com/ is broken |
| [02:41:32] | <colan> | @freenode_jonpugh[m]:matrix.org: that's weird. it wasn't autocompleting before. |
| [02:41:48] | <jonpugh1> | yes I know :) I'm going to be taking down the site shortly... Thank you though |
| [02:43:31] | * hefring has joined #aegir |
| [03:13:24] | <jonpugh1> | helmo42[m]: colan[m] we've got to solve this composer install issue in core ASAP. It's more of a decision making problem than an engineering one. |
| [03:19:58] | <colan> | @freenode_jonpugh[m]:matrix.org: can we go with helmo42 's idea to have hosting_composer implement your hosting_git hook? |
| [03:20:26] | <colan> | then we just need to get hosting_composer into golden/experimental. |
| [03:20:45] | <jonpugh1> | that module is too much. I don't like the fact that it has even more dependencies :( |
| [03:21:06] | <jonpugh1> | This functionality can be done with very little code in hosting_platform.module |
| [03:21:26] | <jonpugh1> | hosting_site should have the "hooks" |
| [03:21:50] | <colan> | i've been playing with it a bit. seems to do the trick, but yeah, does need a bunch more modules. |
| [03:22:26] | <colan> | that's an option. helmo42 ergonlogic thoughts? ^^^ |
| [03:22:28] | <jonpugh1> | I don't like how we keep putting good ideas into half-baked contrib modules instead of improving core |
| [03:23:02] | <jonpugh1> | hosting_git data should be directly in hosting_platform right next to makefile data |
| [03:23:03] | <colan> | i believe the idea is to be part of core via golden. |
| [03:23:18] | <colan> | so as to keep the actual core small. |
| [03:23:44] | <jonpugh1> | if it's included in the distro, I consider that "core". |
| [03:23:51] | <jonpugh1> | users don't know what "golden contrib" is, just that it's part of aegir |
| [03:24:19] | <jonpugh1> | we already confuse the hell out of users by having two modules for load balancing (pack or cluster), two modules now for HTTPS... |
| [03:24:39] | <jonpugh1> | we need to clean up |
| [03:25:51] | <ergonlogic[m]> | what "bunch more modules/dependencies" are you referring to? hosting_composer has exactly 1 dependency, aegir_objects |
| [03:26:26] | <jonpugh1> | features? |
| [03:26:39] | <ergonlogic[m]> | That's inaccurate, check the .info |
| [03:27:05] | <ergonlogic[m]> | I suppose one of the sub-modules might require feature |
| [03:27:18] | <jonpugh1> | Aegir objects completely changes how you write a contrib module, I don't like the idea of having one module using it. If you think it's useful, put it into hosting-7.x-4.x |
| [03:27:48] | <ergonlogic[m]> | because it makes fields exportable more easily and consistently, rather than manage yet more of our own db tables |
| [03:27:58] | <ergonlogic[m]> | Several others use it too, iirc |
| [03:28:12] | <colan> | ergonlogic: I believe jon's right here - I had to install features for something along the line. |
| [03:28:59] | <ergonlogic[m]> | right, the submodules |
| [03:29:06] | <colan> | but yeah, if those are from one of the submodules, you can leave them off if just using hosting_git. |
| [03:32:51] | <colan> | @freenode_jonpugh[m]:matrix.org: we can't rewrite everything at once to use aegir_objects, but if it's in core, other modules can start using it. |
| [03:33:12] | <colan> | I don't really see how it's a bad thing per se, if it makes module-writing easier. |
| [03:33:37] | <colan> | Sounds like a reasonable option for the framework to have. |
| [03:35:34] | <colan> | Given that we wouldn't be breaking anything by putting in in aegir 3, I'm not really sure what the problem is. Can definitely go into 4 too of course. |
| [03:42:27] | <colan> | anyway, @freenode_jonpugh[m]:matrix.org makes a good point. reducing confusion is good. i don't know anything about pack/cluster (never used that stuff), but we should prioritize getting hosting_https and a coimposer solution in core. |
| [03:42:29] | <colan> | These issues are already in the release plan https://www.drupal.org/project/hostmaster/issues/2927652, but we actually need to work on them. |
| [03:47:44] | * hefring has joined #aegir |
| [04:20:46] | * reaper013 has quit (Quit: Page closed) |
| [05:54:22] | <jonpugh1> | Anyone up for a quick review of a simple patch with a big impact? https://www.drupal.org/project/hosting/issues/2936013 |
| [05:55:12] | <jonpugh1> | helmo42[m]: |
| [05:55:27] | <helmo42[m]> | I'll check it out |
| [06:05:05] | <helmo42[m]> | Hi all, ergonlogic bgm jonpugh colan cweagans gboudrias memtkmcc .. and any one else ... Scrum time? |
| [06:05:38] | <helmo42[m]> | In response to the conversation earlier today ... I'm open to including the composer needs natively in Aegir core, +1 for reducing complexity |
| [06:05:44] | <helmo42[m]> | The only real advantage I can still see in having it as a separate module is that you can turn it off and not be bothered by the option. At the moment we have no way to get rid of the makefile fields when a user chooses to always use Git. |
| [06:06:07] | * jonpugh1 waves |
| [06:06:54] | <bgm> | i have a small patch for civicrm that is rather important, if anyone can review the regexp: https://www.drupal.org/project/provision/issues/2926905 - we've been running it in production for a while now. |
| [06:08:00] | <helmo42[m]> | johnpugh: I' looking at your Add "Edit Platform" tab to Site node page. patch ... looks good. I've just confirmed that it's not visible for regular client users ... so the access hook seems to function as intended. |
| [06:08:47] | <jonpugh1> | great... yes it just passes through to the existing access and page callbacks |
| [06:10:45] | <jonpugh1> | but I don't know where you get "john" from :) |
| [06:12:26] | <helmo42[m]> | sorry riot isn't autocompleting j<TAB> to you as it only knows you as freenode_.... |
| [06:12:53] | <jonpugh1> | doh, sorry! |
| [06:13:04] | <jonpugh1> | I'll have to fix that... |
| [06:14:28] | <helmo42[m]> | bgm: not using nginx much ... but I would have expected the ? |
| [06:14:29] | <helmo42[m]> | after the (/\w\w/) thing to make that grouping optional |
| [06:16:16] | <bgm> | helmo42[m]: hmm.. indeed |
| [06:16:43] | <bgm> | i'll double-check and update the PR, will ping again next week :) |
| [06:16:44] | <bgm> | thx |
| [06:17:31] | <colan> | @freenode_jonpugh i think it's because you're using riot as an irc client. You're not in the Matrix room. |
| [08:08:29] | <helmo42[m]> | colon: I've created https://www.drupal.org/project/hosting_https/issues/2936056 to discuss final review of hosting_https ... all old issues have now been migrated to D.o |
| [08:25:27] | * joestewart has quit (Ping timeout: 240 seconds) |
| [08:26:17] | * joestewart_ has quit (Ping timeout: 252 seconds) |
| [08:27:20] | * joestewart has joined #aegir |
| [08:27:30] | * joestewart_ has joined #aegir |
| [08:43:02] | <bgm> | https://github.com/aegir-project/provision/pull/16/files -> fixed the regexp, and double-checked/tested that this is what we are running in production |
| [08:49:21] | * joestewart has quit (Ping timeout: 256 seconds) |
| [08:49:33] | * joestewart_ has quit (Ping timeout: 264 seconds) |
| [08:51:10] | * joestewart has joined #aegir |
| [08:51:30] | * ybabel has quit (Quit: ybabel) |
| [08:52:14] | * joestewart_ has joined #aegir |
| [09:35:31] | * theMusician has quit (Ping timeout: 240 seconds) |
