| [13:22:10] | * s-mutin has joined #aegir |
| [14:08:02] | * TaoStyle has quit (Quit: leaving) |
| [18:59:21] | * ybabel has joined #aegir |
| [19:14:43] | * reaper013 has joined #aegir |
| [19:49:06] | * Tirant_lo_Blanc has joined #aegir |
| [22:58:51] | * reaper013 has quit (Quit: Page closed) |
| [02:10:47] | * theMusician has joined #aegir |
| [03:00:25] | * TaoStyle has joined #aegir |
| [03:11:58] | * theMusician has quit (Ping timeout: 252 seconds) |
| [05:11:48] | <jonpugh> | helmo42[m]: I'm not seeing your changes in the issue branch for https://www.drupal.org/project/provision/issues/2937147 |
| [05:11:49] | <hefring> | https://www.drupal.org/project/provision/issues/2937147 => Add Composer support directly to Provision. [#2937147] => 22 comments, 2 IRC mentions |
| [05:57:16] | <helmo42[m]> | jonpugh: It's on both gitlab and D.o |
| [05:58:13] | <jonpugh> | ahhhh my branch didn't have an upstream |
| [05:58:22] | <jonpugh> | because I'm in the place I originally created it |
| [06:06:06] | <jonpugh> | helmo42[m]: FYI if you prefix your commits with "Issue #NUM:" it will log the commit in the comment chain |
| [06:07:08] | <helmo42[m]> | yeah... I keep thinking of that after I push :( |
| [06:07:17] | <jonpugh> | :D |
| [06:07:31] | <jonpugh> | I'm making a small change to how we check for composer, see my note in the issue |
| [06:16:31] | <helmo42[m]> | jonpugh: ok |
| [06:16:49] | <jonpugh> | just pushed. Works well. |
| [06:26:15] | <helmo42[m]> | jonpugh: The extra docs are nearly the same as in provision.api.php ... might be better to just name the vars there and point to the provision.api.php |
| [06:26:24] | <jonpugh> | yes, cleaning up now :) |
| [06:26:38] | <jonpugh> | I didn't see it because my git pull didn't work |
| [06:27:26] | <helmo42[m]> | I'm not seeing the moved shell_exe though |
| [06:29:33] | <jonpugh> | It's there... http://cgit.drupalcode.org/provision/tree/platform/verify.provision.inc?... |
| [06:30:17] | <jonpugh> | http://cgit.drupalcode.org/provision/commit/?id=82cf956 |
| [06:30:34] | <helmo42[m]> | I have it now :) |
| [06:31:22] | <jonpugh> | ok, I think we are good to merge? |
| [06:31:23] | <jonpugh> | :D |
| [07:27:52] | <colan> | jonpugh: helmo42 so how will Composer get installed? is it shipped with the debian package? |
| [07:28:07] | <jonpugh> | yep |
| [07:28:13] | <jonpugh> | helmo did that part |
| [07:28:47] | <colan> | ok, cool. |
| [07:28:53] | <jonpugh> | ok, passed on github and gitlab |
| [07:30:49] | * ybabel has quit (Quit: ybabel) |
| [07:42:48] | <jonpugh> | merged. Aegir now supports composer install 🎆 |
| [07:43:32] | <jonpugh> | you know, it strikes me as strange we don't just have a "profile" field in node/add/platform. "drush dl $profile" is just as secure as "drush make $url" |
| [07:43:51] | <colan> | jonpugh: don't remore the deployment strategies stuff from the docs; we'll be adding that back. (I added a comment to issue there for where we'll be working on that.) |
| [07:44:35] | <colan> | https://www.drupal.org/project/hosting_composer/issues/2938992 |
| [07:44:36] | <hefring> | https://www.drupal.org/project/hosting_composer/issues/2938992 => Enhance composer support in Aegir core [#2938992] => 4 comments, 2 IRC mentions |
| [07:52:34] | <jonpugh> | colan: that page doesn't explain how to get those features as the module is not included in aegir. Those features shouldn't be in the hosting_composer module. I don't think that feature should be included in aegir 3.x at all. |
| [07:52:55] | <jonpugh> | perhaps if you want to add that to 7.x-4.x |
| [07:55:00] | <colan> | jonpugh: the plan is to add hosting_deploy (or whatever it'll be called) to golden. it's really important for users to be able to know what their options are. for example, it's a bad idea to run a git pull task on a Prod aegir instance for most use cases. this alerts users to that. |
| [07:56:04] | <jonpugh> | That module is not fit for 3.x. It changes too much. |
| [07:56:38] | <jonpugh> | And it really needs work, regardless |
| [07:56:41] | <colan> | jonpugh: how so? |
| [07:57:17] | <jonpugh> | really? It introduces an entirely new paradigm for coding things for aegir, for one. |
| [07:57:18] | <colan> | i'm already using it for a client project. :) |
| [07:57:26] | <jonpugh> | that's fine |
| [07:57:32] | <jonpugh> | golden contrib means ships with aegir |
| [07:57:47] | <jonpugh> | nothing is stopping you from writing modules compatible with aegir |
| [07:57:57] | <colan> | jonpugh: that paradigm is optional, but it's not changing the existing api. |
| [07:58:14] | <jonpugh> | it's more clutter we don't need. 3.x is already a mess |
| [07:58:30] | <jonpugh> | if you want to maintain 7.x-4.x you can release 4.0.0 now |
| [07:58:43] | <jonpugh> | I am being serious, I'm only really interested in provision 4. |
| [07:58:51] | <colan> | but it allows for things to be cleaned up somewhat... that's actually the idea. |
| [07:58:56] | <colan> | anyway, up to helmo42 i guess. |
| [07:59:10] | <colan> | for 3, that is. |
| [07:59:38] | <jonpugh> | > but it allows for things to be cleaned up somewhat... |
| [07:59:47] | <jonpugh> | and THAT is the idea of incremental version numbers:) |
| [08:00:46] | <colan> | but i mean you can write cleaner contrib code if we add that hosting_deploy dependency. |
| [08:00:59] | <jonpugh> | Great. In 4.x |
| [08:01:14] | <jonpugh> | 4.0.0 could release as stable right now as a branch of 3.x |
| [08:01:19] | <colan> | as opposed to jumping through all of the traditional aegir3 hoops. |
| [08:01:20] | <jonpugh> | then just add your stuff |
| [08:01:35] | <jonpugh> | colan: I am not disagreeing with your motivations |
| [08:01:44] | <jonpugh> | I'm saying this is not the way to do it. |
| [08:02:33] | <jonpugh> | 4.x is a great way to follow through on that |
| [08:02:46] | <jonpugh> | and convert everything else to use the new "better way" |
| [08:02:52] | <colan> | personally, i'll be doing as little as possible deveopment on aegir3 (only if required by client projects, and they can't wait until 5). other than that, i'll mostly be putting time into aegir5. |
| [08:03:42] | <jonpugh> | then considering not you nor anyone else actually wants to maintain this code, please leave it out of aegir core. you can always add it to your hostmaster as needed. |
| [08:03:58] | <jonpugh> | and so can anyone else that wants to write code this way. |
| [08:04:47] | <colan> | I never said I wouldn't support it; I said I'll do as little as necessary. as in, if i need it, i'll suppot it. |
| [08:05:41] | <jonpugh> | which is exactly why this should not ship with aegir. |
| [08:06:08] | <jonpugh> | aegir is filled with modules that we added with that level of commitment to maintain :) |
| [08:06:54] | <colan> | let's cross that bridge when we get to it as it's quite possible I won't get to it. |
| [08:07:40] | <colan> | honestly, i don't think i'll be doing much with aegir4 (sorry). |
| [08:08:55] | <colan> | if that stuff gets merged into 3.x, fine, but if it's a whole new thing, i'll be putting my efforts towards 5. |
| [08:15:10] | <jonpugh> | that's great, colan. It can be added to the documentation as an interesting contrib project, but I do not think it is good for golden contrib. |
| [08:25:53] | * TaoStyle has quit (Quit: leaving) |
| [08:33:54] | * TaoStyle has joined #aegir |
| [08:36:10] | * TaoStyle has quit (Client Quit) |
| [08:36:55] | * TaoStyle has joined #aegir |
| [09:00:37] | * TaoStyle has quit (Quit: leaving) |
| [09:24:08] | * Tirant_lo_Blanc has quit (Ping timeout: 252 seconds) |
| [09:24:23] | * calbasi has quit (Ping timeout: 256 seconds) |
