| [18:37:21] | * ybabel has joined #aegir |
| [19:42:59] | * calbasi has joined #aegir |
| [20:43:54] | * mstenta has quit (Ping timeout: 265 seconds) |
| [00:49:00] | * shaneonabike1 has joined #aegir |
| [01:16:00] | * mstenta has joined #aegir |
| [01:30:24] | * shaneonabike1 has left #aegir ("PART #drupal-commerce :PING 1517927424") |
| [01:43:59] | <helmo42[m]> | I did find an upgrade issue ... https://www.drupal.org/project/hostmaster/issues/2942500 |
| [01:44:00] | <hefring> | https://www.drupal.org/project/hostmaster/issues/2942500 => Upgrade to 3.14.0 issue [#2942500] => 2 comments, 1 IRC mention |
| [02:04:47] | * theMusician has joined #aegir |
| [02:04:59] | * joestewart_ has quit (Ping timeout: 256 seconds) |
| [02:06:19] | * joestewart_ has joined #aegir |
| [02:22:14] | <jonpugh> | helmo42[m]: perhaps we just roll back that entire patch? |
| [02:28:18] | <helmo42[m]> | That would be the safest option :( |
| [02:28:52] | * theMusician has quit (Quit: theMusician) |
| [02:29:28] | * theMusician has joined #aegir |
| [02:30:31] | <jonpugh> | I'm sorry, I should have said something... maybe this should be the start of 7.x-4.x |
| [02:30:35] | * calbasi has quit (Ping timeout: 240 seconds) |
| [02:32:47] | <jonpugh> | actually, helmo42[m] .... |
| [02:32:56] | <jonpugh> | I think your hotfix could be the way to go |
| [02:34:49] | <jonpugh> | I'm confused, though, isn't it already doing this somewhere? $task->task_command = 'provision-' . $task->task_type; |
| [02:36:23] | <helmo42[m]> | yes but that's in a hook_load() ... the drush_hosting_task_validate() function is creating a node object and directly storing it in a drush context |
| [02:36:50] | <jonpugh> | yeah |
| [02:36:59] | <jonpugh> | I just found it : hosting_task_hosting_tasks_alter |
| [02:37:11] | <jonpugh> | That's what sets "provision-$COMMAND" |
| [02:37:27] | <jonpugh> | ok, yeah hotfix patch is best |
| [02:37:56] | <jonpugh> | thinking on it a few more minutes |
| [02:38:37] | <jonpugh> | Yes. I think what you are doing there is best |
| [02:45:45] | <jonpugh> | helmo42[m]: I think you are good to go with your patch https://www.drupal.org/project/hostmaster/issues/2942500#comment-12469316 |
| [02:45:46] | <hefring> | https://www.drupal.org/project/hostmaster/issues/2942500 => Upgrade to 3.14.0 issue [#2942500] => 4 comments, 2 IRC mentions |
| [02:47:28] | * noecc has joined #aegir |
| [03:28:47] | * calbasi has joined #aegir |
| [04:21:10] | * yaazkal[m] has joined #aegir |
| [04:31:35] | * drastik-jw has quit (Ping timeout: 240 seconds) |
| [04:32:07] | * drastik-jw has joined #aegir |
| [05:33:45] | * Yaazkal has joined #aegir |
| [05:41:35] | * calbasi has quit (Quit: Leaving) |
| [06:57:54] | * Yaazkal has quit (Remote host closed the connection) |
| [07:15:53] | * ybabel has quit (Quit: ybabel) |
| [07:26:01] | * noecc has left #aegir ("pax") |
| [07:43:49] | <jonpugh> | Hey helmo42[m] ... I'm here if you need assistance |
| [08:03:01] | <helmo42[m]> | jonpugh: I'm now in the http://docs.aegirproject.org/en/3.x/community/release-process/debian-pac... process ... but that was only designed for provision updates .. so I'm extending it to include hostmaster and hosting |
| [08:16:14] | <helmo42[m]> | It's weird, the upgrade test should have cought this ... but it only started failing after the release was done. See https://gitlab.com/aegir/provision/pipelines |
| [08:17:43] | <helmo42[m]> | This morning I got the first fail mail ... not sure why I didn't get the one from https://gitlab.com/aegir/provision/pipelines/17101768 just after the relese :( |
| [08:27:07] | <helmo42[m]> | Found it ... the upgradetest mentions 'The following packages have been kept back' ... due to the added composer package suggestion :( |
| [08:31:37] | * mstenta has quit (Ping timeout: 260 seconds) |
| [08:38:47] | * ybabel has joined #aegir |
| [08:39:51] | * ybabel has quit (Client Quit) |
| [09:20:20] | * theMusician_ has joined #aegir |
| [09:20:37] | * theMusician has quit (Ping timeout: 260 seconds) |
| [09:20:37] | * theMusician_ is now known as theMusician |
| [10:14:16] | * theMusician has quit (Quit: theMusician) |
| [10:58:54] | * theMusician has joined #aegir |
