IRC logs for #aegir, 2018-04-12 (GMT)

2018-04-11
2018-04-13
TimeNickMessage
[10:30:34]* realityloop has joined #aegir
[10:31:07]* realityloop has left #aegir ()
[16:40:20]* ybabel has joined #aegir
[18:20:26]* ybabel has quit (Quit: ybabel)
[18:29:58]* ybabel has joined #aegir
[02:17:58]* mengi has joined #aegir
[02:32:53]* kavi has joined #aegir
[02:33:20]<kavi>Hi, after upgrading to 3.144 we are missing git checkout task in aegir ?
[02:33:27]<kavi>what should i look for ?
[03:19:52]<helmo42[m]>kavi: if the hosting_git_checkout module is enabled, and if the user has the relevant permissions ... and if the site or platform has git meta data
[03:21:51]<kavi>Create a git-checkout task for sites - this permission is missing from list of permission
[03:21:57]<kavi>and i think that is the issue
[03:41:23]<kavi>access_callback($node,$type) in hosting_task.module is returning false
[03:41:33]<kavi>what permission is this checking ?
[03:43:57]<helmo42[m]>kavi: the callback defined in the array in hosting_git_checkout_hosting_tasks()
[03:44:36]* helmo42[m] sent a long message: helmo42[m]_2018-04-12_17:44:36.txt <https://matrix.org/_matrix/media/v1/download/matrix.org/DvWLMLdVkxaxdqnl...
[03:46:58]<kavi>those two permissions are set in aegir - create site git-checkout task and create platform git-checkout task
[03:47:05]<kavi>both are checked true
[03:49:24]<helmo42[m]>and is your node showing a git url?
[03:51:32]<kavi>yes
[03:51:36]<kavi>git pull is working
[03:51:48]<kavi>only git checkout is missing
[03:53:56]<kavi>access_callback($node,$type) - which function does it call ??
[03:55:55]<helmo42[m]>It should be calling hosting_git_checkout_access_checkout()
[03:57:36]<kavi>hosting_git_checkout_access_checkout() - this doesnt take parameters
[03:57:43]<kavi>node,type
[03:58:58]<helmo42[m]>It only takes the node parameter, and ignores the other one
[04:01:15]<kavi>ok then those two permissions are set
[04:08:21]<helmo42[m]>kavi: do you see then when your logged in as user 1?
[04:09:34]<kavi>am an administrator on the site
[04:10:09]<kavi>so i should see wat user 1 is seeing
[04:11:22]<helmo42[m]>"should" :) but I've seem nore strange things happen
[04:14:14]* noecc has joined #aegir
[04:26:36]<helmo42[m]>Hi all, ergonlogic bgm jonpugh colan cweagans gboudrias memtkmcc .. and any one else ... Scrum time?
[04:27:33]* jonpugh waves
[04:27:44]<jonpugh>Provision4 BoF went well yesterday
[04:28:55]<kavi>hmm i found the mistake but not sure why - git checkout is looking for user_access('create site git-checkout task') but i have 'create git-checkout task' the site is missing
[04:30:28]<helmo42[m]>jonpugh: good to hear, are you enjoying Nashville?
[04:31:03]<jonpugh>It's a Boot-scootin good time ;)
[04:31:31]<jonpugh>There was an Interesting BoF on adding Console commands to core
[04:32:12]<bgm>Any thoughts on how to run testing on aegir 3rd-parties, such as hosting_civicrm?
[04:32:45]<bgm>for now, I have a runner connected to gitlab.com, but people post .patch files on drupal.org, and it's annoying to have to process them manually
[04:33:15]<helmo42[m]>kavi: That looks like a bug then ... should be easy to fix though
[04:33:43]<jonpugh>The Travis files kind of work, we should make something standard we can drop into all aegir contrib projects
[04:34:07]<jonpugh>See the .travis.yml file in hosting.module
[04:34:16]<kavi>who should we tell to fix the bug
[04:34:44]<bgm>jonpugh: does d.o support that?
[04:35:02]<jonpugh>Maybe? I haven't tried the built in testing
[04:35:10]<jonpugh>However for Aegir... Probably not
[04:35:27]<jonpugh>The behat tests run the backend commands as well
[04:37:45]<bgm>d.o has lots of obscure references to simpletest :)
[04:38:51]<helmo42[m]>kavi: https://www.drupal.org/project/issues/hosting_git?categories=All
[04:49:59]* kavi has quit (Quit: Page closed)
[05:25:59]* ybabel has quit (Quit: ybabel)
[05:49:08]<helmo42[m]>I just added two random goals on https://opencollective.com/aegir ... who can improve on that?
[06:12:57]* noecc has quit (Ping timeout: 265 seconds)
[09:34:32]* ghoti65 has joined #aegir
[09:36:34]* ghoti65 has quit (Remote host closed the connection)
[09:54:35]* NeilHanlonkd has joined #aegir
[09:56:37]* NeilHanlonkd has quit (Remote host closed the connection)