IRC logs for #aegir, 2018-10-18 (GMT)

2018-10-17
2018-10-19
TimeNickMessage
[15:48:14]* Yaazkal has quit (Quit: Connection closed for inactivity)
[19:08:26]* Shwele has joined #aegir
[20:40:08]* ybabel has joined #aegir
[20:42:13]* ybabel has quit (Client Quit)
[22:28:40]* Shwele has quit (Ping timeout: 252 seconds)
[22:37:43]* shaneonabike has joined #aegir
[22:39:34]* Shwele has joined #aegir
[01:28:44]<Shwele>drupal security update is out, is there going to be aegir update soon tm? :D
[01:32:11]* shaneonabike has quit (Quit: Leaving.)
[01:40:41]<Shwele>a question: If master server is doing backup of aegir instances, is it backing up databases from the slave server somehow or just the files? Its been on my mind for some time and due that backups are stored on master server it seems like files only and that is not redundant.
[01:55:33]<helmo42[m]>i intend to do a minor Aegir release this evening...
[01:55:45]<Shwele>good...
[01:56:34]<helmo42[m]>@shwele backups do include an sql- dump
[01:58:24]<Shwele>Oh really, that is sure handy then, I was worried about that if its needed to additionally be setup!
[02:06:27]* shaneonabike has joined #aegir
[02:09:55]* shaneonabike has quit (Client Quit)
[02:35:37]* Shwele has quit (Quit: Leaving)
[05:15:47]<helmo42[m]>Hi all, ergonlogic bgm jonpugh colan cweagans gboudrias memtkmcc .. and any one else ... Scrum time?
[05:16:27]<helmo42[m]>GitLan CI is hard at work testing the 3.16.1 release .... follow it live on https://gitlab.com/aegir/provision/pipelines/33480801
[05:17:37]<jonpugh>Excellent
[05:22:46]<bgm>jonpugh: any thoughts on this hosting_git issue? https://www.drupal.org/project/hosting_git/issues/3006600
[05:22:48]<hefring>https://www.drupal.org/project/hosting_git/issues/3006600 => Regression: cannot enter the Git URL when creating a new platform [#3006600] => 4 comments, 1 IRC mention
[05:29:21]<jonpugh>Uhh
[05:30:07]<helmo42[m]>I'll try and see if I can bend my brain on that if statement
[05:30:20]<jonpugh>Sorry about that. I should make it clearer
[05:40:52]<helmo42[m]>Removing the '&& isset($node->git['repo_url']' part seems to solve it.... or does that break another usecase?
[05:52:13]<jonpugh>helmo42[m]: seems like it should be fine,
[05:52:24]<jonpugh>but it might be there to avoid a warning if git info isn't there
[05:52:32]<jonpugh>put the && isset($node->git['repo_url']) on the #default_value?
[05:53:00]<jonpugh>We should revert the removed IP address too...
[05:55:20]<helmo42[m]>I'm testing on a dev server now ... but it broke on the extra rules module I have there.
[05:55:30]<helmo42[m]>Which needed an update (php 7.2)
[05:57:38]<helmo42[m]>jonpugh: the #default_value keys in that code block already has such isset() checks
[05:57:52]<jonpugh>ah, then yeah, get rid of it.
[06:00:23]<helmo42[m]>about the IP ... that's related to https://www.drupal.org/project/hosting_git/issues/2981195
[06:00:24]<hefring>https://www.drupal.org/project/hosting_git/issues/2981195 => Update IP ranges whitelist for webhook access [#2981195] => 9 comments, 2 IRC mentions
[06:18:54]<helmo42[m]>All done ... CU later
[06:49:51]<bgm>thanks for the fix!