| [19:38:26] | * ybabel has joined #aegir |
| [19:38:54] | * ybabel has quit (Client Quit) |
| [20:12:09] | * Shwele has joined #aegir |
| [20:56:06] | * ybabel has joined #aegir |
| [20:56:11] | * ybabel has quit (Client Quit) |
| [00:39:08] | * shaneonabike has joined #aegir |
| [02:30:19] | * shaneonabike has left #aegir () |
| [02:59:14] | * Shwele has quit (Quit: Leaving) |
| [05:06:58] | * theMusician has quit (Ping timeout: 246 seconds) |
| [06:15:05] | <jonpugh> | helmo: Any chance for a quick review before the weekend? https://www.drupal.org/project/provision/issues/3012687 |
| [06:15:06] | <hefring> | https://www.drupal.org/project/provision/issues/3012687 => Allow d() to pass through normal drush alias properties. [#3012687] => 2 comments, 1 IRC mention |
| [06:56:21] | <helmo42[m]> | jonpugh (IRC): a quick one ... I still have to do a server migration tonight |
| [06:56:31] | <helmo42[m]> | Is the `isset($drush_alias[$name]` commented intentionally? |
| [06:57:32] | <helmo42[m]> | I remember using provision sync to work on a non-Aegir alias... maybe that code got changed only later one |
| [06:57:49] | <jonpugh> | oops, on |
| [06:57:50] | <jonpugh> | no |
| [06:59:16] | <helmo42[m]> | Hmm I may have introduced that myself in http://cgit.drupalcode.org/hosting_tasks_extra/commit/?id=f59051a5a04d50... |
| [06:59:32] | <jonpugh> | haha yep |
| [06:59:33] | <jonpugh> | that's it |
| [06:59:39] | <jonpugh> | but this is better anyway :) |
| [06:59:58] | <helmo42[m]> | true |
| [07:00:11] | <jonpugh> | that ltrim is in the d(), isn't it? |
| [07:00:33] | <jonpugh> | new patch OTW |
| [07:01:08] | <helmo42[m]> | yes I think d() does that |
| [07:04:19] | <jonpugh> | yeah it's in provision_normalise_context_name() |
| [07:04:21] | <jonpugh> | in d() |
| [07:04:37] | <jonpugh> | weird... not sure why not Context::_construct() |
| [07:04:43] | <jonpugh> | helmo42[m]: new patch is up there |
| [07:09:31] | <helmo42[m]> | looks OK visually ... lets see what CI thinks ... I just pushed that branch to gitlab |
| [07:09:32] | <helmo42[m]> | https://gitlab.com/aegir/provision/pipelines/36072663 |
| [07:09:53] | <helmo42[m]> | rtbc if it passes :) |
| [07:13:33] | <jonpugh> | :+1 |
| [07:24:34] | <helmo42[m]> | passed |
